Newswires UI: fix offline banner #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sb-dev
force-pushed
the
fix-offline-banner
branch
from
a7fd63a to
b7dd6dd
Compare
sb-dev
force-pushed
the
fix-offline-banner
branch
4 times, most recently
from
f21c720 to
604ea53
Compare
bryophyta
reviewed
Jan 23, 2025
newswires/client/src/App.tsx
Outdated
| css={css` | ||
| ${status === 'offline' && 'padding-top: 84px;'} | ||
| height: 100%; | ||
| ${(status === 'loading' || status === 'error') && 'display: flex;'} |
There was a problem hiding this comment.
Suggested change
| ${(status === 'loading' || status === 'error') && 'display: flex;'} | |
| ${(status === 'loading' || status === 'error') && 'display: flex; align-items: center;'} |
iiuc these rules are coupled, so to my mind it makes sense to have them both in the same expression? not blocking though
bryophyta
approved these changes
Jan 23, 2025
sb-dev
force-pushed
the
fix-offline-banner
branch
2 times, most recently
from
e9afb90 to
6686430
Compare
sb-dev
force-pushed
the
fix-offline-banner
branch
from
6686430 to
3342070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Make the offline banner fixed so it can remain visible when scrolling through stories.
How to test
How can we measure success?
Have we considered potential risks?
Images
Accessibility